search

apple / swift-openapi-generator

Generate Swift client and server code from an OpenAPI document.
https://swiftpackageindex.com/apple/swift-openapi-generator/documentation
Apache License 2.0
1.45k stars 121 forks source link

[Generator] Add support of deepObject style in query params #659

Open arthurcro opened 1 month ago

arthurcro commented 1 month ago

Motivation

The generator changes for: https://github.com/apple/swift-openapi-generator/issues/259

Depends on https://github.com/apple/swift-openapi-runtime/pull/100 landing first and getting released, and the version dependency being bumped here.

Modifications

Added deepObject style to serializer & parser in order to support nested keys on query parameters.

Result

Support nested keys on query parameters.

Test Plan

Adapted snippet tests (SnippetBasedReferenceTests)

czechboy0 commented 1 month ago

We discussed this offline, this is the PR https://github.com/apple/swift-openapi-generator/pull/538 reopened again, so that we can finish it up even while the original author is busy 🙂 Thanks @arthurcro for adding you both to the commit, it's important that we give credit to @kstefanou52 for the work already done!

czechboy0 commented 1 month ago

Kicked off CI to see what state we're in.

arthurcro commented 1 month ago

Thank you for the review @czechboy0! I'll start taking a look at those changes asap! 🙂

kstefanou52 commented 1 month ago

Sorry, I couldn’t find the time to complete this PR yet. I made some progress, but there seems to be an issue with the unit tests—possibly something with the runtime library. I’ll have some time this weekend, so if @arthurcro would like any help, please let me know.

arthurcro commented 1 month ago

Sorry, I couldn’t find the time to complete this PR yet. I made some progress, but there seems to be an issue with the unit tests—possibly something with the runtime library. I’ll have some time this weekend, so if @arthurcro would like any help, please let me know.

Thanks for the update @kstefanou52! I've got some availability this weekend too and would be happy to help . If you'd prefer to complete it yourself given the progress you've made, that's completely fine - just let me know what works best for you!

kstefanou52 commented 1 month ago

Sorry, I couldn’t find the time to complete this PR yet. I made some progress, but there seems to be an issue with the unit tests—possibly something with the runtime library. I’ll have some time this weekend, so if @arthurcro would like any help, please let me know.

Thanks for the update @kstefanou52! I've got some availability this weekend too and would be happy to help . If you'd prefer to complete it yourself given the progress you've made, that's completely fine - just let me know what works best for you!

Thank you so much for the understanding @arthurcro. I'm just giving it a try and I will let you know about the outcome until Sunday end of the day.