search

apple / swift-openapi-urlsession

URLSession transport for Swift OpenAPI Generator.
https://swiftpackageindex.com/apple/swift-openapi-urlsession/documentation
Apache License 2.0
160 stars 33 forks source link

Update CI to use release 5.10 image #47

Closed glbrntt closed 8 months ago

simonjbeaumont commented 8 months ago

@swift-server-bot add to allowlist

glbrntt commented 8 months ago

5.10 is failing because strict concurrency checking and warnings as errors are enabled.

The concurrency checking emits a warning because of the generated test file which contains a static array of test classes, and XCTestCase isn't Sendable.

Do you have a preference for which option to disable?

czechboy0 commented 8 months ago

contains a static array of test classes

~Maybe we can just move it to be a fileprivate global let in the file, to avoid coupling it to the (non-Sendable) XCTestCase subclass?~

Sorry, misread your message. Yeah, not sure. @briancroom what's the recommendation here?

simonjbeaumont commented 8 months ago

Do you have a preference for which option to disable?

I thought I'd check the runtime and generator repos for precedence here and found that we have disabled strict-concurrency in one and warnings-as-errors in the other 🤦.

Ideally we'd disable neither but don't have a strong opinion about the stopgap solution. Let's make sure we file an issue to cover getting back to belt-and-braces. The longer it's disabled, the harder it's gonna be to enable again.

//cc @czechboy0

glbrntt commented 8 months ago

I disabled strict concurrency checking for now and filed https://github.com/apple/swift-openapi-urlsession/issues/49 to re-enable it.

I also filed a radar against SwiftPM.