Remove unnecessary self keyword

apple / swift-openapi-urlsession

URLSession transport for Swift OpenAPI Generator.

https://swiftpackageindex.com/apple/swift-openapi-urlsession/documentation

Apache License 2.0

159 stars 31 forks source link

Remove unnecessary self keyword #48

Closed Nao-RandD closed 6 months ago

Nao-RandD commented 7 months ago

Motivation

We want to avoid redundant code by removing unnecessary self keywords

Modifications

Removed unnecessary self keywords

Result

No errors, ./scripts/soundness.sh also passed.
- Follow this reference

Test Plan

[Describe the steps you took, or will take, to qualify the change - such as adjusting tests and manual testing.]

czechboy0 commented 7 months ago

@swift-server-bot test this please

czechboy0 commented 6 months ago

@simonjbeaumont

simonjbeaumont commented 6 months ago

First off: sorry for the time it took to notice the PR; I've been OOO recently.

Thanks for taking the time here and for caring about consistent style :)

I'm in principle happy for us to adopt this more consistently—we have a similar style in the other swift-openapi-* repos—but I'd like to preserve the contents of Sources/BufferedStream/* as-is, because they have been vendored in from another project and we explicitly ignore any of the swift-format rules for these files^0.

Happy to take the rest of the PR though, and I'm happy to update it, to save you the work.

Nao-RandD commented 6 months ago

@simonjbeaumont Thanks for confirming this.

I understand that you want to keep the contents of Sources/BufferedStream/* intact.

I have restored the relevant modifications with 11343861770fb7defa44f33fcca77bbbc627a3a6 , so please check again.

simonjbeaumont commented 6 months ago

@swift-server-bot test this please