search

apple / swift-protobuf

Plugin and runtime library for using protobuf with Swift
Apache License 2.0
4.55k stars 443 forks source link

ci.swift.org: Failing tests Required.Proto3.JsonInput.EmptyFieldMask.* #834

Closed benlangmuir closed 5 years ago

benlangmuir commented 5 years ago

All of the swift-protobuf jobs on ci.swift.org have been failing on the Required.Proto3.JsonInput.EmptyFieldMask.* tests.

Example failures: https://ci.swift.org/job/swift-protobuf-linux-ubuntu-14_04/898 https://ci.swift.org/job/swift-protobuf-linux-ubuntu-16_04//917

18:36:48 CONFORMANCE TEST BEGIN ====================================
18:36:48 
18:36:48 ERROR, test=Required.Proto3.JsonInput.EmptyFieldMask.ProtobufOutput: Failed to parse input or produce output. request=json_payload: "{\"optionalFieldMask\": \"\"}" requested_output_format: PROTOBUF message_type: "protobuf_test_messages.proto3.TestAllTypesProto3" test_category: JSON_TEST, response=parse_error: "JSON failed to parse: malformedFieldMask"
18:36:48 ERROR, test=Required.Proto3.JsonInput.EmptyFieldMask.JsonOutput: Failed to parse input or produce output. request=json_payload: "{\"optionalFieldMask\": \"\"}" requested_output_format: JSON message_type: "protobuf_test_messages.proto3.TestAllTypesProto3" test_category: JSON_TEST, response=parse_error: "JSON failed to parse: malformedFieldMask"
18:36:48 
18:36:48 These tests failed.  If they can't be fixed right now, you can add them to the failure list so the overall suite can succeed.  Add them to the failure list by running:
18:36:48   ./update_failure_list.py Sources/Conformance/failure_list_swift.txt --add failing_tests.txt
18:36:48 
18:36:48   Required.Proto3.JsonInput.EmptyFieldMask.JsonOutput
18:36:48   Required.Proto3.JsonInput.EmptyFieldMask.ProtobufOutput
18:36:48 
18:36:48 CONFORMANCE SUITE FAILED: 831 successes, 0 skipped, 0 expected failures, 2 unexpected failures.
benlangmuir commented 5 years ago

Started failing after a change to https://github.com/google/protobuf

Commit 7f42d6d0bcadb286aa5120bc60441d4b56bacd93 by github
Fix empty FieldMask json encoding/decoding (#5605)
* Fix empty FieldMask json encoding/decoding

* Add failed test to python's conformance failure list
thomasvl commented 5 years ago

Looking to figure out what the issue with the test is.