search

apple / swift-service-context

Minimal type-safe context propagation container
https://github.com/apple/swift-distributed-tracing
Apache License 2.0
66 stars 22 forks source link

Remove dependencies and expose Baggage directly #13

Closed slashmo closed 3 years ago

slashmo commented 3 years ago

Closes #12

With the focus shifting to automatic context propagation through task-locals, this PR removes LoggingContext (and the dependency on Logging) and exposes a new BaggageModule, containing the pure Baggage implementation formerly defined in apple/swift-distributed-tracing-baggage-core.

One addition over the original Baggage implementation is the task-local Baggage.$current. This will allow us to perform automatic context propagation behind the scenes, enabling an easier distributed tracing API overall. (The new Tracing API with structured concurrency support will follow next).

swift-server-bot commented 3 years ago

Can one of the admins verify this patch?

swift-server-bot commented 3 years ago

Can one of the admins verify this patch?

swift-server-bot commented 3 years ago

Can one of the admins verify this patch?

swift-server-bot commented 3 years ago

Can one of the admins verify this patch?

swift-server-bot commented 3 years ago

Can one of the admins verify this patch?

ktoso commented 3 years ago

@swift-server-bot test this please

slashmo commented 3 years ago

@tomerd The docker and script files should be good now. Could you please review them once more, and set up the CI to stop executing with 5.0 and 5.1 and add 5.4 & 5.5 instead?

ktoso commented 3 years ago

@swift-nio-bot add to allowlist

ktoso commented 3 years ago

LGTM, and the 5.0 5.1 are expected failures 👍

ktoso commented 3 years ago

@swift-server-bot test this please

ktoso commented 3 years ago

Removed 5.1 and 5.0 CI, but it still shows up here, i guess we may need to make a new PR with the same contents @slashmo

yim-lee commented 3 years ago

I removed 5.0 and 5.1 from branch rules so they are no longer required.

slashmo commented 3 years ago

@yim-lee & @ktoso: Thanks for taking care of the CI. Re-triggering with a new (or amended) commit seems to work 👍