search

apple / swift-service-context

Minimal type-safe context propagation container
https://github.com/apple/swift-distributed-tracing
Apache License 2.0
66 stars 22 forks source link

Adjust API Availability for Structured Concurrency Backport #18

Closed moritzsternemann closed 2 years ago

moritzsternemann commented 2 years ago

As the Swift Structured Concurrency backport is now available with the release of Xcode 13.2, I adjusted the API availability guards to enable these features on previous OS versions.

I'll also open a follow-up PR in swift-distributed-tracing.

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

ktoso commented 2 years ago

@swift-server-bot test this please

ktoso commented 2 years ago

Yeah the #if also has to be adjusted to what we explain in the adoption guidelines: https://github.com/swift-server/guides/blob/main/docs/concurrency-adoption-guidelines.md#if-guarding-code-using-concurrency

ktoso commented 2 years ago

Our "good friend" jazzy messing up builds again, I'll fix this.

slashmo commented 2 years ago

Our "good friend" jazzy messing up builds again, I'll fix this. @ktoso

Now that DocC seems to be able to generate static websites as well (https://github.com/apple/swift-docc/pull/56), I think we can ditch Jazzy as soon as possible.

ktoso commented 2 years ago

Very true, to be honest perhaps let's not even waste energy on jazzy anymore.

ktoso commented 2 years ago

@swift-server-bot test this please

ktoso commented 2 years ago

I updated the check: https://github.com/apple/swift-distributed-tracing-baggage/pull/18/commits/46faa2a1be2c95c22f5c181276996d7d9ce75e33

Would you mind doing the same in the other repo @moritzsternemann ?

ktoso commented 2 years ago

@swift-server-bot add to allowlist