search

apple / swift-service-discovery

A service discovery API for Swift.
https://swiftpackageindex.com/apple/swift-service-discovery/documentation
Apache License 2.0
213 stars 21 forks source link

Improve subscription handling #9

Closed yim-lee closed 4 years ago

yim-lee commented 4 years ago

Motivation:

  1. There is no way to cancel a subscription today
  2. Caller has no way of knowing when a subscription terminates

Modifications:

Result: Caller can cancel subscription and gets notified when subscription terminates.

yim-lee commented 4 years ago

great catch about cancelable subscriptions

Thanks @Lukasa for catching it

tomerd commented 4 years ago

looks good, couple of comments