search

apple / swift-system

Low-level system calls and types for Swift
Apache License 2.0
1.18k stars 102 forks source link

Quote cmake include path #109

Closed krzyzanowskim closed 2 years ago

krzyzanowskim commented 2 years ago

quote include path that helps if path contains eg. a space

milseman commented 2 years ago

@compnerd can you take a look?

krzyzanowskim commented 2 years ago

refer to the CMAKE_MODULE_PATH which shouldn't require quoting if handled properly IIRC

long story short: swift won't build if checkout to path with space

When building swift-project using build-script if fails randomly here and there, and this is one place where it fail to include cmake macros from a path with spaces.

compnerd commented 2 years ago

@krzyzanowskim I think that you misunderstood me, I agree that this site should be quoted. I think that the "quote cmake include path" is a bit confusing is all. This is an include, but the quoting is applied to a parameter. The "CMake include path" is normally the CMAKE_MODULE_PATH, which is not being touched here and is confusing because you expect the diff to be different.

compnerd commented 2 years ago

@swift-ci please test

compnerd commented 2 years ago

I don't think that the commit message is worth keeping this open. Going to merge it.