Plot & explore JavaScript errors aren't debuggable without stack traces

apple / turicreate

Turi Create simplifies the development of custom machine learning models.

BSD 3-Clause "New" or "Revised" License

11.2k stars 1.14k forks source link

Plot & explore JavaScript errors aren't debuggable without stack traces #2137

Open znation opened 5 years ago

znation commented 5 years ago

Theoretically, we can get stack traces from WebKit and JavaScriptCore using this API: https://stackoverflow.com/questions/34273540/ios-javascriptcore-exception-detailed-stacktrace-info

We probably need to implement this in several places:

tcviz client app (macOS)
vega_renderer

znation commented 5 years ago

And we should make sure we have debuggable JS assets (non-minified) in debug builds of Turi Create, so that the call stacks that get printed are readable.

znation commented 5 years ago

Moving to 5.8 since actually getting call stacks will be more extensive; we need to switch from using file:// to http:// URLs (backed by boost::beast as the localhost web server).