search

apple / turicreate

Turi Create simplifies the development of custom machine learning models.
BSD 3-Clause "New" or "Revised" License
11.18k stars 1.13k forks source link

Automatically package dylib zip files #3004

Open TobyRoseman opened 4 years ago

TobyRoseman commented 4 years ago

Our GitLab CI File build all necessary dylibs (see build_dylib_ios_12 and build_dylib_macos_10_15 tasks). However it seem only the dylibs from build_dylib_macos_10_15 are include in the final artifact (i.e. the output of the collect_artifacts task). I suspect this is the result of a name conflict (the dylib output files are named same thing in both build_dylib_ios_12 and build_dylib_macos_10_15). We should fix this.

Also currently when doing a TuriCreate release, there is a required manual step to package the two recommender dylibs together and the two audio dylib together. Then we need to manually zip these two folders. We should eliminate this manual step by having our GitLab CI, create the two final zip files automatically.

TobyRoseman commented 4 years ago

This issue is related to #3023, which is a P1 issue in this milestone. Once #3023 is resolved, this issue will likely no longer be applicable. Removing this issue from the 6.2 milestone.