search

appleboy / drone-jenkins

Drone plugin for trigger Jenkins jobs.
MIT License
38 stars 17 forks source link

XSRF heandling with test-jenkins-dataset #25

Closed geopossachs closed 2 years ago

geopossachs commented 5 years ago

24

add an test jenkins with start via docker-compose add xsrf handling into the client add some log message into the code add a xsrf test function

codecov-io commented 5 years ago

Codecov Report

Merging #25 into master will increase coverage by 1.47%. The diff coverage is 86.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
+ Coverage   86.95%   88.42%   +1.47%     
==========================================
  Files           2        2              
  Lines          69      121      +52     
==========================================
+ Hits           60      107      +47     
- Misses          7       10       +3     
- Partials        2        4       +2
Impacted Files Coverage Δ
jenkins.go 87.77% <86.11%> (+2.67%) :arrow_up:
plugin.go 90.32% <0%> (-0.59%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update beee0b4...f187152. Read the comment docs.

appleboy commented 5 years ago

Why add jenkins_data?

geopossachs commented 5 years ago

I have set up an jenkins in docker with two demo jobs to check if the XSRF handling is working. I have add the jenkins_home volume into the git as jenkins_data to rerun the test again on my externel drone ci server.

It is not so nice that the jenkins folder is so big. It contains not only the confiiguratioin but also parts of the application itself. :-( One more reason for drone.io :-)

codecov-commenter commented 3 years ago

Codecov Report

Merging #25 into master will increase coverage by 1.91%. The diff coverage is 86.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
+ Coverage   86.51%   88.42%   +1.91%     
==========================================
  Files           2        2              
  Lines          89      121      +32     
==========================================
+ Hits           77      107      +30     
  Misses         10       10              
- Partials        2        4       +2
Impacted Files Coverage Δ
jenkins.go 87.77% <86.11%> (+3.29%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c81cb41...f187152. Read the comment docs.