search

appleboy / drone-ssh

Drone plugin for executing remote ssh commands
MIT License
239 stars 73 forks source link

Have a setting for not autoloading .env data #239

Closed albertyw closed 1 year ago

Polectron commented 1 year ago

Yes please, the last update broke my ci pipeline. I'm using appleboy/ssh-action to deploy a django application which has a .env with DEBUG=on, this breaks drone-ssh because it doesn't have the expected format. Honestly I think drone-ssh should never load a .env by default, it should be opt in to load it.

albertyw commented 1 year ago

I created two pull requests for this issue:

242 adds the ability for a user to disable automatically loading .env files. It is backwards compatible.

243 disables automatically loading .env files. It is not backwards compatible but it is simpler.

The two conflict with each other so only one can be merged. I personally would prefer #243.