search

appleboy / gin-jwt

JWT Middleware for Gin framework
MIT License
2.77k stars 388 forks source link

fix(timezone): remove stray `UTC()` call #309

Closed UndeadBaneGitHub closed 1 year ago

UndeadBaneGitHub commented 1 year ago

Only in TokenGenerator mw.TimeFunc().UTC() is called (all other places do not call UTC), making the result inconsistent with the result of other functions.

UndeadBaneGitHub commented 1 year ago

This should be fixing a related issue: https://github.com/appleboy/gin-jwt/issues/296 (opened the PR before skimming through them)

codecov-commenter commented 1 year ago

Codecov Report

Merging #309 (63974a5) into master (d213dd0) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #309   +/-   ##
=======================================
  Coverage   87.36%   87.36%           
=======================================
  Files           1        1           
  Lines         459      459           
=======================================
  Hits          401      401           
  Misses         45       45           
  Partials       13       13
Flag Coverage Δ
go-1.17 ?
go-1.18 87.36% <100.00%> (ø)
go-1.19 87.36% <100.00%> (ø)
ubuntu-latest 87.36% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
auth_jwt.go 87.36% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.