search

appleboy / react-recaptcha

A react.js reCAPTCHA for Google
https://www.google.com/recaptcha/intro/index.html
BSD 3-Clause "New" or "Revised" License
635 stars 97 forks source link

Pre commit broken on Windows. #219

Open hbowden opened 6 years ago

hbowden commented 6 years ago

I'm trying to create a few pull requests but the pre-commit hook is broken for me. I looked in the package.json and I see the pre-commit runs lint and test. I ran those commands individually and they both pass but I can't commit with git in this repo. Below is the results of running lint and test then trying to commit. The very bottom of the image is the error message I am receiving.

pre-commit-hook

It appears that pre-commit is broken on Windows: https://github.com/observing/pre-commit/issues/102

Can we remove the pre-commit hook and let CI take care of that? Because this repo is mostly unusable on Windows in it's current state.

andyfry01 commented 6 years ago

@hbowden this was broken for me too, although now I think it should be working. See line 10 and 11 in package.json. Previously pre commit was running test with a --watch flag, which was stalling the commit. Now pre commit runs test without --watch, so I think it will work for you.

hbowden commented 6 years ago

@andyfry01 No, this is still very much broken on Windows. Any ideas @appleboy or @andyfry01 ?

appleboy commented 6 years ago

I think we can remove the pre-commit hooks since we can just run the testing and lint in Travis CI.