search

applegrew / django-select2

This is a Django integration for Select2
MIT License
712 stars 314 forks source link

Make it easier to get the testapp running + document it #610

Closed hartwork closed 4 years ago

hartwork commented 4 years ago

Note that the auto-migration bits in here are for convenience. I consider them a feature but if you consider it more of a problem, I'm happy to drop that bit. :beers:

codecov-commenter commented 4 years ago

Codecov Report

Merging #610 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #610   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines            8         8           
=========================================
  Hits             8         8

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2d8a536...a87ad12. Read the comment docs.

hartwork commented 4 years ago

I am not so sure the test app serves well as an example app. It can't provide all edge cases needed for a comprehensive test suite and be a good and simple sample. Furthermore, it does not have any initial data. So even after running the migration, you still can't use it.

I agree. Some of them have some data — see heavy_select2_multiple_widget — but still.

Maybe the better demo is simply going to select2.org and test the demo there.

select2.org demos something with zero Django so I don't think it's a good demo for django-select2, personally.

I'd rather put more effort in the quick start guide, to help people get select2 running in their own application.

I see two distinct aspects/questions here:

In my eyes they are independent but I guess that's a question of view. This pull request is about (a) and (a) only. If you consider this going backwards, no hard feelings on my side, let's closes the PR. I won't be able to help about (b) shortly.

PS: I have dropped the auto-migration magic now (which was a product of trying to get :memory: and migrations work together, originally) which maybe served less value than justified by the complexity.

codingjoe commented 4 years ago

hm… ok, I think I'd prefer a separate app, with some initial data loaded via fixtures. Doesn't need to be big but give someone an idea on how everything works. I don't think it's wise to mix those two. I will close the PR for now. Feel free to submit a sample app. Thanks! Joe