search

applejag / Newtonsoft.Json-for-Unity.Converters

Converters of common Unity types for Newtonsoft.Json. Goes hand in hand with jilleJr/Newtonsoft.Json-for-Unity
https://github.com/jilleJr/Newtonsoft.Json-for-Unity.Converters
MIT License
332 stars 37 forks source link

Make AI, Physics, and Physics2D modules optional dependencies #60

Closed SolidAlloy closed 3 years ago

SolidAlloy commented 3 years ago

There's currently no possibility to use Converters with AI or Physics modules being disabled. However, not every project uses the AI module, etc. Thus, I made those modules optional dependencies. I created predefined symbols, like AI_MODULE, through version defines and wrapped code in them so that it is excluded from the compilation when a module is disabled.

SolidAlloy commented 3 years ago

Hi, sorry you've not heard from me for a while. I've applied all the suggestions you mentioned and the project works in both Unity 2018 and newer, so the PR should be good now.

applejag commented 3 years ago

This has now been released: https://github.com/jilleJr/Newtonsoft.Json-for-Unity.Converters/releases/tag/1.3.0

SolidAlloy commented 3 years ago

Great, thanks :)