applepiofmyeye / pe

0 stars 0 forks source link

Adding an empty note to a task is allowed #4

Open applepiofmyeye opened 7 months ago

applepiofmyeye commented 7 months ago

Running the command note 3 n/ or with a space as well note 3 n/ is successful.

I think this is a minor bug but slightly counter-intuitive! Users might accidentally press "Enter" too soon and have to retype the command again. Maybe there could be a restriction against empty notes?

nus-se-bot commented 7 months ago

Team's Response

Thank you for your feedback! Yes we do intend it for note to accept empty strings, and we do not want to over validate the input necessarily as it does not impede on any of our operations, and it makes sense that note can be empty, unlike name. If we validate too much, we might even end up with additional bug below.

However, we do understand the concern of overwriting the previous note, which we have considered under the planned enhancement. In which case, it would be a separate bug under feature flaw.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]