applepiofmyeye / pe

0 stars 0 forks source link

Error messages for invalid index input is inconsistent #5

Open applepiofmyeye opened 7 months ago

applepiofmyeye commented 7 months ago

There seems to be an inconsistency in the error messages for marking indexes of 0 and negative numbers, numbers outside of the list (but small) , as well as extremely large numbers. The error messages for an extremely large number is as follows: Screenshot 2023-11-17 at 5.07.14 PM.png As compared to one that is not as large but out of range Screenshot 2023-11-17 at 5.06.48 PM.png

And compared with a marking the index 0 Screenshot 2023-11-17 at 5.06.24 PM.png

And negative numbers: Screenshot 2023-11-17 at 5.08.15 PM.png

Especially for the case of an extremely large number, the "invalid command" error message might be misleading.

nus-se-script commented 7 months ago

Team's Response

Thanks for your feedback! As of now, for a task number greater than 2,147,483,647, TaskWise does not view any command you give it as a valid command. This is why the error message you have mentioned at the start is as such. As for the second error message, it is the correct message since task number 1234 does not exist. This has been mentioned in our Planned Enhancements, where we will be handling extremely large numbers differently.

As for the third and forth screenshot, the error messages are as such since 0 and -12 are NOT positive integers, as TaskWise only accepts positive integers. However, these 2 would be a separate issue from the first screenshot.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]