Pop URL on open/close video

appleple / modal-video

https://appleple.github.io/modal-video/

MIT License

271 stars 80 forks source link

Pop URL on open/close video #56

Open hejamartin opened 4 years ago

hejamartin commented 4 years ago

Could you dispatch events for when a video is opened/closed? I want to be able to set the URL in the browser through History API.

developerdevice commented 3 years ago

I'll implement this feature.

uidev1116 commented 1 year ago

@hejamartin @developerdevice

The idea sounds good. But sorry I have less motivation to implement it by myself, because I personally won't use the feature on my daily life. If you seriously need it, please fork this repository and implement it the feature, and send me a pull request if needed. I may merge it if it is enough reasonable for this project.