Difference between button and role="button"

appleple / modal-video

https://appleple.github.io/modal-video/

MIT License

271 stars 80 forks source link

Difference between button and role="button" #79

Open kubasto opened 2 years ago

kubasto commented 2 years ago

If the trigger element is a div with a role="button" it doesn't act the same as a regular button - i.e. doesn't accept spacebar and enter keys. I think it should (for accessibility).

uidev1116 commented 1 year ago

@kubasto

Sorry for the late reply.

The idea sounds good. But sorry I have less motivation to implement it by myself, because I personally won't use the feature on my daily life. If you seriously need it, please fork this repository and implement it the feature, and send me a pull request if needed. I may merge it if it is enough reasonable for this project.