appleple / react-modal-video

Accessible React Modal Video Component
https://appleple.github.io/react-modal-video/
MIT License
177 stars 86 forks source link

Issues with updated react transition dependency commit #11

Closed ecjs closed 6 years ago

ecjs commented 6 years ago

When the timeout prop was removed in commit cd406dae8f3389a433cd60c5d39716507a08da81 it created propType errors:

Failed prop type: The prop timeout is marked as required in CSSTransition, but its value is undefined.

I am not super familiar with react-transition-group, but when I looked at the documentation, I only see references to the timeout prop, not the newly added transitionEnterTimeout and transitionLeaveTimeout, I believe these are removed from newer versions.

Am I missing something here?

LucienLee commented 6 years ago

It looks like the author mixed up the v1 and v2 API. The timeout is required unless provide addEventListener. The transitionEnterTimeout is only in v1 api.

Refs:

ghost commented 6 years ago

getting the same error here, clogging up the console

ecjs commented 6 years ago

Do you want a PR to fix this @steelydylan or @plag?

steelydylan commented 6 years ago

@ecjs yes Please give us the PR, if you can.