search

appleple / react-modal-video

Accessible React Modal Video Component
https://appleple.github.io/react-modal-video/
MIT License
177 stars 86 forks source link

Custom URL player not working #30

Open apurvis opened 4 years ago

apurvis commented 4 years ago

Was having problems getting this to work w/a local MP4 file when I noticed that the "custom" button doesn't even work on the demo site for this package: https://rawgit.com/appleple/react-modal-video/master/test/

Which makes me think the problem is not how I've configured it (which is more or less exactly how the demo site does) and some deeper problem with the package?

apurvis commented 4 years ago

cc @ankit307 tested in both chrome and safari

dwalks12 commented 4 years ago

I'm also having an issue running custom video urls but only in iOS Safari. I've attempted using video tags as the children or a custom iframe but am not having any success. I thought it had to do with autoplay or playsinline but that is not the case it seems to be an issue with the video being within a modal.

Does anyone have a solution?

apurvis commented 4 years ago

i would advise not using this library at all and just using the HTML5 <video> tag along with the official well supported react-modal; that solved my problem.

dwalks12 commented 4 years ago

I found another solution. Mine was that the video was not optimized for web so i used https://handbrake.fr/ and selected optimize for web and ran it and now it works.

yvancompaore commented 3 years ago

hi, Do you know how to prevent uploading for our own videos??