upgrading packages - Githubissues

appleple / react-modal-video

Accessible React Modal Video Component

https://appleple.github.io/react-modal-video/

MIT License

177 stars 86 forks source link

upgrading packages #81

Closed llbbl closed 1 year ago

llbbl commented 2 years ago

Goal was to upgrade to the latest react.

I had to remove nightmare because kept wanting to install Electron, wouldn't work with it included
moved babel/cli/core to supported versions
removed node-sass because not supported so using newer dart/node version now
changed a bit under scripts. not all of them working yet fyi.

I bumped the version to 2.0.0, since all dependencies were bumped to major versions.

npm install works fine

llbbl commented 2 years ago

Oh ya removed : babel-preset-es2015

wasn't sure if needed anymore

llbbl commented 2 years ago

This PR will get rid of 7 other dependabot Pull requests 🥇

V3ntus commented 1 year ago

Bump. Please bump the react peerDep's

llbbl commented 1 year ago

@V3ntus I ran npm upgrade and bumped stuff. The react peerDeps can't be updated any more -- not sure what you meant? React 18.3 isn't out yet.

Not sure what to do about the branch conflicts. There been a few small changes and a bump to 1.x version since my fork.

V3ntus commented 1 year ago

The react peerDeps can't be updated any more -- not sure what you meant?

Sorry! Meant to direct that at the maintainer. "If nothing else, at least please bump peerDeps"

grantbriston commented 1 year ago

Sorry guys but I can't wait around, so i've published this as a new package

https://www.npmjs.com/package/react-modal-video-new

mutschelknauss commented 1 year ago

Thanks @llbbl for this PR.

Would be great to have this PR merged in. We are getting console errors & warnings in this otherwise great project due to the lack of React 18+ support.

atsu666 commented 1 year ago

Thanks @llbbl for this PR.