search

appleple / react-modal-video

Accessible React Modal Video Component
https://appleple.github.io/react-modal-video/
MIT License
178 stars 86 forks source link

One of the transitive dependency is depreciated - querystring@0.2.0 #91

Open versatilemage opened 1 year ago

versatilemage commented 1 year ago

In the react-modal-video the transitive dependency querystring is used but It is only updated to @0.2.0 so It throws error when hosting on depreciated packages on querystring version used in react-modal-video so please look into it

uidev1116 commented 1 year ago

@versatilemage

I understand. Would you be able to share the error message with us?

SauravPatel3042 commented 9 months ago

Hello Team,

I have a Vimeo video that contains a Query string in videoId so I can't play it.

Actula link on ifream link is (Two Question mark in link) //player.vimeo.com/video/855810524?h=23cda6f8ac?api=false&autopause=true&autoplay=true&byline=true&loop=false&portrait=true&title=true&xhtml=false

When i made a change link to this (Remove one Question mark and add & instaded of Question mark) //player.vimeo.com/video/855810524?h=23cda6f8ac&api=false&autopause=true&autoplay=true&byline=true&loop=false&portrait=true&title=true&xhtml=false

After i made change than video work properly.

so can you please help me to fix this issue and i am using this "react-modal-video": "^1.2.8" version.