search

appleseedhq / appleseed-max

appleseed plugin for Autodesk® 3ds Max®
https://appleseedhq.net/
MIT License
33 stars 16 forks source link

Add exposure parameter to light material #309

Closed jjeziorski closed 4 years ago

jjeziorski commented 5 years ago

Here's a simple PR for https://github.com/appleseedhq/appleseed-max/issues/32

usakhelo commented 5 years ago

Hi @jjeziorski , This parameter is the synonym of m_light_power right? It's fine I think. Have you tried to open scene saved with previous version of the plugin? We are trying to maintain backward compatibility.

jjeziorski commented 5 years ago

Hi @usakhelo, Thank you for review. I'm not sure if I'd call it synonym of m_light_power, but indeed it modifies light power just using exponential scale.

Yes, I've checked opening old scene and it works for me. Anyway as far as I know, if you keep paramblock definition consistent (ids / types) than scenes are always backward compatible.

usakhelo commented 5 years ago

@jjeziorski this PR should be rebased. Would be great if @dictoon review this. If not let's merge this too, it looks fine to me.

jjeziorski commented 5 years ago

@usakhelo I don't see any conflicts, so rebase should be trivial upon merge (github option). Having said that, please let me know if there are any conflicts/issues.

dictoon commented 5 years ago

Thanks for the contribution @jjeziorski!

usakhelo commented 5 years ago

Thanks @dictoon, I feel much better about this PR now :)

usakhelo commented 5 years ago

@jjeziorski it should rebase with no issues, you are right.