search

appleseedhq / appleseed-max

appleseed plugin for Autodesk® 3ds Max®
https://appleseedhq.net/
MIT License
33 stars 16 forks source link

Introduce alpha parameter to SSS material #315

Closed jjeziorski closed 4 years ago

jjeziorski commented 5 years ago

Here's a PR for this issue https://github.com/appleseedhq/appleseed-max/issues/14

It seems to work fine, but I have two questions:

  1. Where should it be located in UI? At the moment it's in SSS tab, whereas it applies to both SSS and Specular, which might be misleading. However a separate tab for single map seems excessive. Maybe it should be added to bump tab? Though in that case it would need to be removed from Disney material tab. I'm not sure what is the best approach here.
  2. It does not work well with appleseed texture map, whereas it works fine with native Max bitmap node. Is it expected?
dictoon commented 4 years ago

About the UI: I think the "SSS Parameters" section is appropriate. It's consistent with how things are done in the Disney material.

About the appleseed texture map problem: nope, this isn't expected. What's the issue exactly?

In any case, this PR is pretty much perfect, thanks for the quality code, will merge now!