search

appleseedhq / appleseed-max

appleseed plugin for Autodesk® 3ds Max®
https://appleseedhq.net/
MIT License
33 stars 16 forks source link

Fix issues in OSL plugin #335

Closed usakhelo closed 4 years ago

usakhelo commented 4 years ago

Hi, These are changes that fix some of the hidden issues OSL plugin:

  1. Add Version information to the param block
  2. Skip parameters with obsolete flag
  3. Add separate variable to keep param ids for maps
  4. Start bump parameters IDs with 0 (because they are in separate param block) This may potentially break current scenes but it worked on my tests.
  5. Skip parameters with no widget and no connections (Don't remember where this came from but it sounds reasonable. I probably had a case where it failed to add the parameter)
  6. Fix getting correct colors from OSL color default values.

Thanks for review!