Review Glass BSDF. Finish glass energy conservation

appleseedhq / appleseed

A modern open source rendering engine for animation and visual effects

https://appleseedhq.net/

MIT License

2.19k stars 330 forks source link

Review Glass BSDF. Finish glass energy conservation #2340

Open est77 opened 5 years ago

dictoon commented 5 years ago

We should also handle roughness = 0 (exactly zero). It is a common case and a common source of frustration for users.

est77 commented 5 years ago

I tried to do it before and I couldn't match the SpecularBTDF in appleseed. I am not sure if it was because of some bug in Glass (I'd not be surprised) or some other problem.