appleseedhq / appleseed

A modern open source rendering engine for animation and visual effects
https://appleseedhq.net/
MIT License
2.2k stars 329 forks source link

Move `QDir::toNativeSeparators()` calls to `get_open_filename()` and similar functions #2778

Closed dictoon closed 4 years ago

ani1998ket commented 4 years ago

hey @dictoon could you please elaborate on what needs to be done for this particular issue?

oktomus commented 4 years ago

@ani1998ket Take a look at toNativeSeparators calls in the source code. These calls should be done in get_open_filename so that the path returned by get_open_filename always work on all platforms

dictoon commented 4 years ago

To be precise, it will always work on all platforms, regardless of whether toNativeSeparators() is called or not because the / path separator is also supported on Windows. The purpose of this call is just to make log messages nicer.

elite-sheep commented 4 years ago

I would like to look into this issue. Please assign it to me. :D

oktomus commented 4 years ago

@Aaron19960821 No need to assign it, you can just say you are working on it here :)