search

appleseedhq / appleseed

A modern open source rendering engine for animation and visual effects
https://appleseedhq.net/
MIT License
2.2k stars 329 forks source link

Switch to modern connect syntax in appleseed.bench & appleseed.qtcommon #2809

Closed LeaBroudo closed 4 years ago

LeaBroudo commented 4 years ago

My first pass on the "Explicitly give signals and slots when calling connect #2797" issue. I've made all of the signals and slots explicit in /src/appleseed.qtcommon/ and /src/appleseed.bench/.

LeaBroudo commented 4 years ago

I updated doubleslider.cpp to use QOverload. I wasn't able to use qOverload, because that method only works for Qt 5.7 and later. QOverload<>::of does the same thing, and works for earlier Qt versions (plus it's not ugly like the static casts!)

dictoon commented 4 years ago

Thanks @LeaBroudo for your contribution!

To be clear, Qt 5.12 is much newer than Qt 5.6 (12 > 6), not to be mixed up with Qt 5.1.2.

We indeed target Qt 5.12 as a minimum version, but as you noticed appleseed currently builds fine with older versions. The minimum version is stated in the Windows build instructions but not the Linux or macOS ones, our bad.