Enable OSL importance map build in on_render_begin - Githubissues

appleseedhq / appleseed

A modern open source rendering engine for animation and visual effects

https://appleseedhq.net/

MIT License

2.19k stars 329 forks source link

Enable OSL importance map build in on_render_begin #2841

Closed lorentzo closed 4 years ago

lorentzo commented 4 years ago

Intro

This PR is for issue #2808. Investigate there for more introduction information.

Contribution

Moving build_importance_map() from on_frame_begin() to on_render_begin() in OSLEnvironmentEDF. This enables less workload in on_frame_begin().
Moving m_render_device->initialize() before on_render_begin() in initialize_and_render_frame() in masterrenderer.cpp. This enables OSL shader compilation before work in on_render_begin() is performed in entity (this case in OSLEnvironmentEDF entity).

Further work

Passing the shading system as an argument in on_render_begin().