Fixing double wrapping for OSLBRDF, BSDFBlend and BSDFMix children

appleseedhq / appleseed

A modern open source rendering engine for animation and visual effects

https://appleseedhq.net/

MIT License

2.19k stars 329 forks source link

Fixing double wrapping for OSLBRDF, BSDFBlend and BSDFMix children #2889

Closed lorentzo closed 3 years ago

lorentzo commented 4 years ago

Description

This PR related to issue Double wrapping of child BSDFs in BSDFBlend, BSDFMix and OSLBSDF #1243. It fixes double wrapping when OSLBRDF, BSDFBlend or BSDFMix are used. Idea is that BSDFWrapper is not applied if the current wrapped BRDF is OSLBRDF, BSDFBlend or BSDFMix.

NOTE: this PR is also required for #2886.

LZaw commented 4 years ago

Did you verify, if the problem also occurs with bsdf_mix and bsdf_blend? If they do, could you please include a solution for that too, to close #1243 fully?

dictoon commented 3 years ago

Thanks Lovro for your work!

As we discussed previously, we are going with the implementation from #2901.