search

appleseedhq / appleseed

A modern open source rendering engine for animation and visual effects
https://appleseedhq.net/
MIT License
2.19k stars 329 forks source link

Fix orennayarbrdf.cpp: no longer try to normalizes zero vectors. #2910

Open andreasdeclercq opened 3 years ago

andreasdeclercq commented 3 years ago

Calculate the norm of each vector first and do an early return if zero. This avoids asserts in debug mode and divisions by null in release mode.

oktomus commented 3 years ago

Thanks for your contribution @andreasdeclercq !

This avoids asserts in debug mode and divisions by null in release mode.

Can you please explain in which case you get divisions by null ? That would be great if you could provide a scene so that we can test.