Maki's codebase could use a number of improvements, including:
Changing llvm header names in #include directives to not contain the LLVM version number.
Moving property check code out of MakiASTConsumer and into individual files/modules.
Improving Maki's logging functionality to be easier to use/maintain (e.g., maybe enable debug logging by default when Maki is built in debug mode and pipe debug statements to llvm::errs()).
Adding more logging messages about the AST nodes Maki reports macros and their arguments as aligning with.
Reviewing and removing superfluous comments, e.g., commented out logging statements.
These changes will make Maki's code more portable; easier to read, debug, and maintain; and faster to compile.
Ideally we would like to avoid changing Maki's runtime behavior or performance while addressing this issue.
@SilverMight I'm assigning you to this issue so you have an excuse to become more familiar with Maki's code; if you don't have time to work on it between your internship and MerC though that's fine.
Maki's codebase could use a number of improvements, including:
llvmheader names in#includedirectives to not contain the LLVM version number.MakiASTConsumerand into individual files/modules.llvm::errs()).These changes will make Maki's code more portable; easier to read, debug, and maintain; and faster to compile. Ideally we would like to avoid changing Maki's runtime behavior or performance while addressing this issue.
@SilverMight I'm assigning you to this issue so you have an excuse to become more familiar with Maki's code; if you don't have time to work on it between your internship and MerC though that's fine.