appleshill / pe

0 stars 0 forks source link

Duplicate detection for doctors criterion not correct/clear #3

Open appleshill opened 1 week ago

appleshill commented 1 week ago

Screenshot 2024-11-15 at 4.25.30 PM.png

Screenshot 2024-11-15 at 4.27.44 PM.png

Issue: The UG states that:

Duplicate doctors (same name, phone, and email) are not allowed.

Which seems to imply that another doctor being added would only be considered a duplicate if there is already one with the same name and phone and email. However, when a doctor already exists and I attempt to add another doctor with the same name and email but different phone number, there is an error message that the doctor already exists. Thus, the UG isn't quite correct/clear enough about what the criterion for duplicates are.

To replicate, enter the following commands createD n/Dr1 p/91234567 e/dr1@gmail.com a/8 Kent Ridge Drive 359872 createD n/Dr1 p/98765432 e/dr1@gmail.com a/8 Kent Ridge Drive 359872

nus-pe-script commented 1 week ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Does not allow creation of doctor with same name and different phone number

image.png

image.png

image.png

It is possible for two doctors to have the same name and different contact details, so it should be allowed to be added into the system. The UG states that it is considered a duplicate if all three fields are the same, but here the phone number is different and it was still blocked and considered a duplicate.


[original: nus-cs2103-AY2425S1/pe-interim#2982] [original labels: severity.Medium type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.DocumentationBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Medium`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]