search

application-research / autoretrieve

A server to make GraphSync data accessible on IPFS
22 stars 7 forks source link

feat: strip newline from eventrecorder auth file, prepend "Basic " #109

Closed rvagg closed 2 years ago

rvagg commented 2 years ago
  1. Quality of life improvement by stripping off a newline from the auth token file (so you can edit it with vim and not have to care)
  2. Prepend Basic to the string when sending it to the server so you don't need to add that into the file, it's just the key. I don't think we want to pretend there's any other fancy scheme going on so it should be OK hardwiring this. So now the kubernetes config thing just needs to spit that secret directly into that file and it should be fine.
codecov-commenter commented 2 years ago

Codecov Report

Merging #109 (92041df) into master (e861294) will increase coverage by 0.23%. The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
+ Coverage   11.89%   12.12%   +0.23%     
==========================================
  Files          16       16              
  Lines        2152     2152              
==========================================
+ Hits          256      261       +5     
+ Misses       1881     1877       -4     
+ Partials       15       14       -1
Impacted Files Coverage Δ
autoretrieve.go 0.00% <0.00%> (ø)
filecoin/eventrecorder/eventrecorder.go 74.46% <100.00%> (ø)
blocks/manager.go 85.00% <0.00%> (+5.00%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.