application-research / autoretrieve

A server to make GraphSync data accessible on IPFS
22 stars 7 forks source link

fix: unique metric name for queries #127

Closed rvagg closed 1 year ago

rvagg commented 1 year ago

we're reporting queries as if they were retrievals, which is skewing the metrics badly

codecov-commenter commented 1 year ago

Codecov Report

Base: 20.75% // Head: 20.52% // Decreases project coverage by -0.22% :warning:

Coverage data is based on head (10c1295) compared to base (6bf8431). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #127 +/- ## ========================================== - Coverage 20.75% 20.52% -0.23% ========================================== Files 16 16 Lines 2265 2265 ========================================== - Hits 470 465 -5 - Misses 1765 1769 +4 - Partials 30 31 +1 ``` | [Impacted Files](https://codecov.io/gh/application-research/autoretrieve/pull/127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=application-research) | Coverage Δ | | |---|---|---| | [blocks/manager.go](https://codecov.io/gh/application-research/autoretrieve/pull/127/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=application-research#diff-YmxvY2tzL21hbmFnZXIuZ28=) | `80.00% <0.00%> (-5.00%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=application-research). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=application-research)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

rvagg commented 1 year ago

TIL that you need to export a "view" for metrics to get them registered when the instance starts. So none of my new metrics were showing up except for the one with the erroneous duplicate name. I've added views as a second commit here.