application-research / autoretrieve

A server to make GraphSync data accessible on IPFS
22 stars 7 forks source link

feat: more information on already-running errors to see if there's leaks #133

Closed rvagg closed 1 year ago

rvagg commented 1 year ago

We're seeing a lot more of these 'retrieval already running' errors than I'd expect in the logs after an instance has been running for ~half a day. This adds some additional information to the error message to help with tracking it down. Duration because if they've only been running for a few minutes then that's fine. Query/Retrieval expected & completion counts to tell us where they're held up, maybe we have missing events (like https://github.com/application-research/filclient/pull/104).

codecov-commenter commented 1 year ago

Codecov Report

Base: 20.75% // Head: 20.46% // Decreases project coverage by -0.28% :warning:

Coverage data is based on head (3e40335) compared to base (4519510). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #133 +/- ## ========================================== - Coverage 20.75% 20.46% -0.29% ========================================== Files 16 16 Lines 2265 2272 +7 ========================================== - Hits 470 465 -5 - Misses 1765 1776 +11 - Partials 30 31 +1 ``` | [Impacted Files](https://codecov.io/gh/application-research/autoretrieve/pull/133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=application-research) | Coverage Δ | | |---|---|---| | [filecoin/activeretrievals.go](https://codecov.io/gh/application-research/autoretrieve/pull/133/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=application-research#diff-ZmlsZWNvaW4vYWN0aXZlcmV0cmlldmFscy5nbw==) | `63.30% <0.00%> (-3.36%)` | :arrow_down: | | [filecoin/retriever.go](https://codecov.io/gh/application-research/autoretrieve/pull/133/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=application-research#diff-ZmlsZWNvaW4vcmV0cmlldmVyLmdv) | `35.39% <0.00%> (ø)` | | | [blocks/manager.go](https://codecov.io/gh/application-research/autoretrieve/pull/133/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=application-research#diff-YmxvY2tzL21hbmFnZXIuZ28=) | `80.00% <0.00%> (-5.00%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=application-research). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=application-research)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.