application-research / autoretrieve

A server to make GraphSync data accessible on IPFS
22 stars 7 forks source link

Query error metrics #138

Closed hannahhoward closed 1 year ago

hannahhoward commented 1 year ago

Goals

I found out a lot about query errors by looking at the database. We should record these as metrics so they show up in a dashboard.

Implementation

The key insight is that many of our query errors are successful query responses that indicate a provider error.

This adds an error matching + metrics record both on actual query errors as well as query responses that indicate a provider error.

codecov-commenter commented 1 year ago

Codecov Report

Base: 20.23% // Head: 20.03% // Decreases project coverage by -0.20% :warning:

Coverage data is based on head (5316ebe) compared to base (2171a13). Patch coverage: 0.00% of modified lines in pull request are covered.

:exclamation: Current head 5316ebe differs from pull request most recent head d2e81ae. Consider uploading reports for the commit d2e81ae to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #138 +/- ## ========================================== - Coverage 20.23% 20.03% -0.21% ========================================== Files 16 16 Lines 2303 2326 +23 ========================================== Hits 466 466 - Misses 1806 1829 +23 Partials 31 31 ``` | [Impacted Files](https://codecov.io/gh/application-research/autoretrieve/pull/138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=application-research) | Coverage Δ | | |---|---|---| | [filecoin/retriever.go](https://codecov.io/gh/application-research/autoretrieve/pull/138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=application-research#diff-ZmlsZWNvaW4vcmV0cmlldmVyLmdv) | `32.89% <0.00%> (-1.75%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=application-research). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=application-research)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.