search

application-research / autoretrieve

A server to make GraphSync data accessible on IPFS
22 stars 7 forks source link

Use async retrieval for graceful shutdown on progress timeout #144

Closed hannahhoward closed 1 year ago

hannahhoward commented 1 year ago

Goals

Instead of cancelling context when a timeout occurs, attempt to gracefully close the data transfer channel. Uses filclient new Async version of retrieve

codecov-commenter commented 1 year ago

Codecov Report

Base: 20.03% // Head: 20.54% // Increases project coverage by +0.51% :tada:

Coverage data is based on head (2658f5d) compared to base (a926f63). Patch coverage: 53.12% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #144 +/- ## ========================================== + Coverage 20.03% 20.54% +0.51% ========================================== Files 16 16 Lines 2326 2346 +20 ========================================== + Hits 466 482 +16 - Misses 1829 1833 +4 Partials 31 31 ``` | [Impacted Files](https://codecov.io/gh/application-research/autoretrieve/pull/144?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=application-research) | Coverage Δ | | |---|---|---| | [...ecoin/eventrecorder/filelogserver/filelogserver.go](https://codecov.io/gh/application-research/autoretrieve/pull/144/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=application-research#diff-ZmlsZWNvaW4vZXZlbnRyZWNvcmRlci9maWxlbG9nc2VydmVyL2ZpbGVsb2dzZXJ2ZXIuZ28=) | `0.00% <0.00%> (ø)` | | | [filecoin/retriever.go](https://codecov.io/gh/application-research/autoretrieve/pull/144/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=application-research#diff-ZmlsZWNvaW4vcmV0cmlldmVyLmdv) | `34.87% <54.83%> (+1.97%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=application-research). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=application-research)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.