Closed rvagg closed 1 year ago
Base: 20.82% // Head: 21.12% // Increases project coverage by +0.29%
:tada:
Coverage data is based on head (
c5c780f
) compared to base (558e7cd
). Patch coverage: 0.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
activeRetrievals.New()
performs a "is this CID already involved in an active retrieval?" check and will return anErrRetrievalAlreadyRunning
if it is; move the index-filtered metric until after this point to capture this filtering in addition to the per-SP concurrency filtering.I only realised this after watching logs while writing up details on the new funnel metrics .. It does mean we're combing two different filtering into one, but I think that's OK for now. Better to not let this get lost because we lack a clear connection between "indexer candidates I can use" and "got a query response from at least one".