Open rvagg opened 1 year ago
Base: 4.87% // Head: 5.24% // Increases project coverage by +0.36%
:tada:
Coverage data is based on head (
ebf5c4e
) compared to base (4b4dcae
). Patch coverage: 12.14% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
DRAFT for now because it's using https://github.com/filecoin-project/lassie/pull/41
@elijaharita I'd like your eyes on this for the synchronous call in the provider,
provider.retriever.Retrieve()
now blocks, holding up one of the goroutines while a retrieval attempt happens. Most of them still fail from indexer lookup fails but the ones that attempt may cause a backlog.Is there any mechanism in here to prevent an excessive backlog of tasks on the
retrievalQueue
that we can't process fast enough to keep up with incoming? I don't see it but I might be missing something. I'm also not experiencing a huge queue while running this locally but that might change when on a faster open network.