search

application-research / autoretrieve

A server to make GraphSync data accessible on IPFS
22 stars 7 forks source link

build: make Makefile keep extern/filecoin-ffi properly in sync #83

Closed rvagg closed 2 years ago

rvagg commented 2 years ago

As long as we're not relying on submodules, let's go whole-hog and get the Makefile to make sure we're in sync and fix it up if it's not. Arguably not as necessary with clean removing extern, but this should be helpful for dev & testing when it's in flux as it adds rev check to each run.

kylehuntsman commented 2 years ago

I tried building the docker image, and I'm running into problems with another dependency that I also verified is a problem on master. Since we run make in the docker build, I want to make sure the docker image still builds before merging this.

$ DOCKER_BUILD_KIT=1 docker build -t autoretrieve .

@elijaharita Taking a look at the Docker build process and not having enough context to how ffi is built, do we still need the rust dependencies?

Turned out to be a local caching problem with Docker BuildKit. It looks like pruning the BuildKit cache or running build without the BuildKit works. We also still need the rust dependencies for FFI.