application-research / autoretrieve

A server to make GraphSync data accessible on IPFS

22 stars 7 forks source link

Continuous Integration #95

Closed hannahhoward closed 2 years ago

hannahhoward commented 2 years ago

Goals

Aapprently @rvagg has been stealthily working on continuous integration setup while on vacation.

On the one hand, this is unacceptable because he should prioritize time off.

On the other hand, I am happy to tidy his work so we can get CI running!

codecov-commenter commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@db99a91). Click here to learn what that means. The diff coverage is n/a.

@@           Coverage Diff            @@
##             master     #95   +/-   ##
========================================
  Coverage          ?   8.35%           
========================================
  Files             ?      12           
  Lines             ?    1592           
  Branches          ?       0           
========================================
  Hits              ?     133           
  Misses            ?    1456           
  Partials          ?       3

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update db99a91...4f683e8. Read the comment docs.

rvagg commented 2 years ago

Yeah, so re how I was attacking this: I grabbed the unified-ci stuff and was pruning pieces to get it working. So far turning off off 32-bit tests, Windows and removing Go 1.17. Then adding pieces to get ffi wired up. BUT it's not that simple, because the linting pieces all go down into extern/filecoin-ffi which it's not happy with. If you don't include ffi then staticcheck missing imports), and go mod tidy will fail. But if you add it, then if you add it then gofmt and staticcheck fail because ffi isn't clean and it wants to go down in there and test. My next step was to figure out how to find a middle ground that gives us some linting - like maybe changing the order in which ffi gets loaded in. But I don't have good ideas yet unfortunately. More tinkering needed probably.

hannahhoward commented 2 years ago

yea I solved this for now by excluding extern from the gofmt command -- see current commit finally passing.

rvagg commented 2 years ago

cleaned up a bit, removed some unnecessary bits and fixed up comments