application-research / delta-ui

7 stars 0 forks source link

57 feature show timestamps in local timezone #71

Closed LucRoy closed 1 year ago

LucRoy commented 1 year ago

Let me know how you guys feel about this one. It introduces a new menu item settings for setting preferences. Currently we only have 'Display in local time' but I can see this growing potentially.

Screenshot 2023-06-08 at 11 59 12 AM

jcace commented 1 year ago

Hey @LucRoy great implementation.

From the UX side, I'm wondering if we want to create some visual difference between the Settings and the rest of the items on the menu bar.

Since the other menus (Providers, Profiles, Datasets, etc) are all related to the DDM schema/dealmaking, whereas this is a separate setting which only impacts the frontend.

I'm thinking - what if this is a gear icon next to the title (o on the bottom of the sidebar) that pops open a separate Settings page?

Super rough mockups:

Top:

Screenshot 2023-06-08 at 12 08 08 PM

Bottom of sidebar

Screenshot 2023-06-08 at 12 12 46 PM
LucRoy commented 1 year ago

@jcace I've change the setting menu to be attached at the bottom with a gear icon. I think it loos way better now. Screenshot 2023-06-12 at 11 06 44 AM