search

application-research / estuary-www

https://estuary.tech
https://estuary.tech
Other
35 stars 31 forks source link

show file pinning status #124

Closed en0ma closed 1 year ago

en0ma commented 1 year ago
Screenshot 2022-12-07 at 09 32 54

NB: do not merge, wait for this https://github.com/application-research/estuary/pull/691

neelvirdy commented 1 year ago

my point with our last discussion on this was that i think we should do something a bit more elegant in how we render the statuses. it's a lot of real estate (especially for smaller devices) to have a column that says pinned most of the time. could we try using tooltipped icons for each status instead? and ideally avoiding having a column name for the status

also, we should think about combining the upload page with the files table, so there's an upload button in the same view and it's guaranteed that users uploading via the UI will see the statuses change as the upload and pinner progress

en0ma commented 1 year ago

my point with our last discussion on this was that i think we should do something a bit more elegant in how we render the statuses. it's a lot of real estate (especially for smaller devices) to have a column that says pinned most of the time. could we try using tooltipped icons for each status instead? and ideally avoiding having a column name for the status

I understand the real estate issue (the major reason I consolidated the retrieval link and filename). I am not sure what the tooltip approach would look like, so long as we let the users see the file pinning status(as it can easily help debug the deal stage, which is what I am aiming for), I am good.

Also, I am not so good with UI work, who can I get to assist me try out a tooltip?

neelvirdy commented 1 year ago

my point with our last discussion on this was that i think we should do something a bit more elegant in how we render the statuses. it's a lot of real estate (especially for smaller devices) to have a column that says pinned most of the time. could we try using tooltipped icons for each status instead? and ideally avoiding having a column name for the status

I understand the real estate issue (the major reason I consolidated the retrieval link and filename). I am not sure what the tooltip approach would look like, so long as we let the users see the file pinning status(as it can easily help debug the deal stage, which is what I am aiming for), I am good.

Also, I am not so good with UI work, who can I get to assist me try out a tooltip?

i can assist on this and/or contribute pieces of it. makes sense to me to split it up as the following:

  1. (optional) combine upload page and files page
  2. add material icons lib https://mui.com/material-ui/material-icons/?theme=Outlined
  3. make a PinStatusIcon component that takes the pinning status as a prop and renders a MuiSvgIcon with a tooltip. i.e. pinning => SyncOutlined, pinned => PublishedWithChangesOutlined, failed => SyncProblemOutlined
  4. render PinStatusIcon next to the row in the files table, passing content.pinningStatus into the props
  5. (optional) if you want to get fancy after doing (1), you can track the browser uploading state and add another status to the icon that is browser-only and renders the DownloadingOutlined icon in PinStatusIcon

lmk if you need more assistance or want me to take any piece of this

neelvirdy commented 1 year ago

closing in favor of https://github.com/application-research/estuary-www/pull/136