search

application-research / estuary-www

https://estuary.tech
https://estuary.tech
Other
35 stars 31 forks source link

Bump next to 13, Use Link for prefetching #143

Closed neelvirdy closed 1 year ago

neelvirdy commented 1 year ago
  1. Bump next and related packages according to https://beta.nextjs.org/docs/upgrade-guide#nextjs-version
  2. Replace <a> tags with <Link> to pickup prefetching benefits from next 13: https://beta.nextjs.org/docs/routing/linking-and-navigating#link-component
  3. check for null hrefs since they break <Link>

This results in ~30% faster loading of estuary-www pages visited through a link within estuary-www.

screen recording demoing jumping between links on a production build:

https://user-images.githubusercontent.com/2850013/208543818-b95c4f42-adb4-48ef-9b0a-92786b0ebb51.mov

alvin-reyes commented 1 year ago

Looks good! Do we have a render preview for this PR?

jimmylee commented 1 year ago

Make sure to update the engine as well, NextJS 13.0.7 requires something newer than 16.8 node

neelvirdy commented 1 year ago

Looks good! Do we have a render preview for this PR?

@alvin-reyes i just added a screen recording to the description