application-research / estuary-www

https://estuary.tech
https://estuary.tech
Other
35 stars 31 forks source link

use content replication over settings replication on deals UI #39

Closed en0ma closed 2 years ago

en0ma commented 2 years ago

Currently, the deals UI uses the settings replication and not the content replication. The content replication is the granular replication value used to maintain deals count. This PR will fix it to use the actual content replication.

I noticed this bug when I change replication count when running estuary, I expected the different contents to have their replication counts maintained depending on the --replication flag or the replication param when the content is created - they did not, the UI kept showing the default instead of the content replication.

Before the fix - this content has a replication of 2 but kept showing 6;

Screenshot 2022-05-23 at 14 26 52

After the fix - UI is now showing the right replication count - 2

Screenshot 2022-05-23 at 14 27 07