application-research / estuary-www

https://estuary.tech

Other

35 stars 31 forks source link

feat: introduce sign-in with cli user #66

Closed alvin-reyes closed 1 year ago

alvin-reyes commented 1 year ago

Changes

added an admin login / cli user login on the frontend.

render[bot] commented 1 year ago

Your Render PR Server URL is https://estuary-pr-66.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-ccjrc5kgqg47pmm205s0.

jimmylee commented 1 year ago

I don't know if this makes sense, If the user was created with the Estuary CLI, wouldn't they just be able to use an API key (which is the same as a sign in token?) and authenticate using the input field on the bottom?

alvin-reyes commented 1 year ago

They would, but they wouldn’t be able to use the user/pass they set from the cli. I think it's best from a UX perspective to show that there is a way for them to use both the user/pass and the API key to log on.

jimmylee commented 1 year ago

Okay I understand better now, let me think on this for a second...

alvin-reyes commented 1 year ago

Posting the slack convo here: https://filecoinproject.slack.com/archives/C016APFREQK/p1664064469797379

alvin-reyes commented 1 year ago

Closing this PR since this is not mandatory to be incorporated on the frontend. Further discussion on slack:

https://filecoinproject.slack.com/archives/C016APFREQK/p1664858875162329?thread_ts=1664823966.311029&cid=C016APFREQK