application-research / estuary-www

https://estuary.tech
https://estuary.tech
Other
35 stars 31 forks source link

Prompt for label when creating key and handle non-stored tokens #90

Closed neelvirdy closed 1 year ago

neelvirdy commented 1 year ago

Phase 2/4 of https://github.com/application-research/estuary/issues/343

Create Key button now prompts the user for a label before generating the key. The generated key is displayed in the modal immediately after. This flow will remain identical once we start omitting the token from the db, except language will be added about tokens not being stored for security.

https://user-images.githubusercontent.com/2850013/200386070-4e6eb3a3-bf70-431c-af52-8cde608b7548.mov

jimmylee commented 1 year ago

LGTM, I would spend some time later making sure the modal is measured appropriately but it works for now.